On Thu, Oct 06, 2011 at 05:06:14PM -0400, Christoph Hellwig wrote: > Instead of passing the block number and mount structure explicitly > get them off the bp and fix make the argument order more natural. > > Also move it to xfs_buf.c and stop printing the device name given > that we already get the fs name as part of xfs_alert, and we know > what device is operates on because of the caller that gets printed. > Only thing I'm wondering about is whether is should be renamed xfs_buf_ioerror_alert(), now that it really is a xfs_buf specific function? Also, many of the callers could probably pass __func__ rather than a manually set string... Otherwise, another nice cleanup. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
