On Sat, Apr 16, 2011 at 08:21:28AM -0400, Theodore Tso wrote:On Apr 16, 2011, at 1:11 AM, Andreas Dilger wrote: In that case, it means cp should just always use FIEMAP_FLAG_SYNC, which is fine.
Except that if someone is copying a large delay allocated file, it will cause
the file to immediately snapped to disk, which might not be the greatest
thing in the world.
Obvious workaround - if the initial fiemap call shows unwrittenextents, redo it with the sync flag set. Though that assumeÑ thatyou can trust things like delalloc extents to only cover the rangethat valid data exists in. Which, of course, you can't assume,either. :/
Always passing FIEMAP_FLAG_SYNC is fine in this case. It should only do anything if there is unwritten data, which is the only case we are concerned with at this point. In any case, this is a simple solution for coreutils until such a time that a more complex solution is added in the kernel (if ever).
Christoph is write, SEEK_HOLE and SEEK_DATA are
a much better API for what cp woulld lke to do. Unfortunately it hasn't
been implemented yet in the VFS...
Agreed, SEEK_HOLE/SEEK_DATA is the right way to solve this problem.
I don't see how this will change the problem in any meaningful way. There will still need to be code that is traversing the on-disk mapping, and also keeping it coherent with unwritten data in the page cache.
Since FIEMAP already exists for most Linux filesystems, it probably makes sense to implement SEEK_{HOLE,DATA} by calling FIEMAP to get the disk mapping in the first place.
I agree that SEEK_{HOLE,DATA} is an easier programming interface, and probably what cp, tar, etc should use, once it is implemented.
Cheers, Andreas |
