On Sat, Apr 16, 2011 at 08:21:28AM -0400, Theodore Tso wrote: > > On Apr 16, 2011, at 1:11 AM, Andreas Dilger wrote: > > > In that case, it means cp should just always use FIEMAP_FLAG_SYNC, which is fine. > > Except that if someone is copying a large delay allocated file, it will cause > the file to immediately snapped to disk, which might not be the greatest > thing in the world. Obvious workaround - if the initial fiemap call shows unwritten extents, redo it with the sync flag set. Though that assumeÑ that you can trust things like delalloc extents to only cover the range that valid data exists in. Which, of course, you can't assume, either. :/ > Christoph is write, SEEK_HOLE and SEEK_DATA are > a much better API for what cp woulld lke to do. Unfortunately it hasn't > been implemented yet in the VFS... Agreed, SEEK_HOLE/SEEK_DATA is the right way to solve this problem. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
