On Mon, 25 Feb 2019 08:55:40 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote: > On Mon, 2019-02-25 at 09:39 +0100, Jesper Dangaard Brouer wrote: > > On Sat, 23 Feb 2019 01:47:00 +0100 > > Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote: > > > > > On 02/22/2019 10:45 PM, Jakub Kicinski wrote: > > > > On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote: > > > > > On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote: > > > > > > Hi! > > > > > > > > > > > > Seems like something funny is going on with get_maintainer.pl since XDP > > > > > > entry got added. We seem to have been CCed on: > > > > > > > > > > I suggest removing the MAINTAINERS line with > > > > > > > > > > K: xdp > > > > > > > > > > as xdp is a pretty generic file/patch content > > > > > regex match for the K: type > > > > > > > > > > $ git grep --name-only xdp | wc -l > > > > > 236 > > > > I'm unsure how K: works, but you grep definitely selects some wrong files. > > > > I tried with "xdp_": > > git grep --name-only xdp_ > > > > That does catch all the driver that have XDP support, which is the > > point of the exercise (to catch drivers). > > > > It does contain a couple of false-positives: > > drivers/net/ethernet/neterion/vxge/vxge-traffic.c > > drivers/thunderbolt/tb_msgs.h > > drivers/thunderbolt/xdomain.c > > sound/soc/codecs/rt5670.c > > > > Via the pattern '[^a-z]xdp_' I'm only left with the thunderbolt > > false-positive, as it have a data struct's called tb_xdp_*. > > Then it's probably better to use > > K: \Wxdp_ > > and if XDP_ is also to be matched, maybe > > K: (?i:\Wxdp_) > The last one seems to be the best at matching the relevant files :-) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
|