On 02/22/2019 10:45 PM, Jakub Kicinski wrote: > On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote: >> On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote: >>> Hi! >>> >>> Seems like something funny is going on with get_maintainer.pl since XDP >>> entry got added. We seem to have been CCed on: >> >> I suggest removing the MAINTAINERS line with >> >> K: xdp >> >> as xdp is a pretty generic file/patch content >> regex match for the K: type >> >> $ git grep --name-only xdp | wc -l >> 236 >> >> Rather more files than desired. >> >> The N: match is dubious too. >> >> It's generally better to have specific lists of >> maintained file patterns rather than using the >> K: and N: pattern matches. >> >> --- >> MAINTAINERS | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d7ad97b235ec..aa703e2cb882 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -16970,7 +16970,6 @@ F: include/net/xdp.h >> F: kernel/bpf/devmap.c >> F: kernel/bpf/cpumap.c >> F: include/trace/events/xdp.h >> -K: xdp >> N: xdp >> >> XDP SOCKETS (AF_XDP) > > Thanks for the explanation, at least now I know why it happens! :) > I'll leave it to Daniel to decide if we really need it removed, > so far the false positives weren't overwhelming, just surprising. No strong opinion. I've seen this K+N pattern in a number of places in the maintainers file. I'm fine either way if it gets too noisy. :)
|