Hi all.[snip]
[snip]
Changelog: Implementing a default behavior for SPI_GETGRADIENTCAPTIONS flag in SystemParametersInfoA. Adding call to TabCtrl_SetPadding in TAB_WindowProc.
Index: dlls/comctl32/tab.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/tab.c,v retrieving revision 1.78 diff -u -r1.78 tab.c --- dlls/comctl32/tab.c 17 Mar 2003 04:43:26 -0000 1.78 +++ dlls/comctl32/tab.c 23 Mar 2003 08:52:10 -0000 @@ -3075,7 +3075,7 @@ return 0;
case TCM_SETPADDING: - FIXME("Unimplemented msg TCM_SETPADDING\n"); + TabCtrl_SetPadding (hwnd, wParam, lParam); return 0;
case TCM_GETROWCOUNT: Index: windows/sysparams.c =================================================================== RCS file: /home/wine/wine/windows/sysparams.c,v retrieving revision 1.49 diff -u -r1.49 sysparams.c --- windows/sysparams.c 19 Feb 2003 22:04:46 -0000 1.49 +++ windows/sysparams.c 23 Mar 2003 08:52:12 -0000 @@ -1734,7 +1734,14 @@ WINE_SPI_FIXME(SPI_SETCOMBOBOXANIMATION); /* 0x1005 _WIN32_WINNT >= 0x500 || _WIN32_WINDOW > 0x400 */ WINE_SPI_FIXME(SPI_GETLISTBOXSMOOTHSCROLLING);/* 0x1006 _WIN32_WINNT
= 0x500 || _WIN32_WINDOW > 0x400 */
WINE_SPI_FIXME(SPI_SETLISTBOXSMOOTHSCROLLING);/* 0x1007 _WIN32_WINNT
= 0x500 || _WIN32_WINDOW > 0x400 */
- WINE_SPI_FIXME(SPI_GETGRADIENTCAPTIONS); /* 0x1008 _WIN32_WINNT >= 0x500 || _WIN32_WINDOW > 0x400 */
First off. Thank you for your attempt to contribute to the wine project. There are however some problems with your patch that need to be fixed.
You have included two copies of the patch (one inline and one attached). Please only include one.
Unfortunatly your inline version got line wrapped so it is turned to garbage. Outlook is not very frendly with with inlined patches and almost always wants to mangle them somehow.
The attached one is not any better
Content-Type: application/octet-stream; name="patch.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="patch.diff"
Please see section 5.2.1 of the following link obout how to correct this.
http://www.winehq.com/Docs/wine-devel/style-notes.shtml
Giving the patch the extention .txt is the simplest way of fixing this problem and is acceptable to to all.
? out.txt=0A= ? patch.diff=0A= ? library/Makefile=0A= ? library/libwine.so.1.0=0A= ? ole/Makefile=0A= ? unicode/Makefile=0A= ? unicode/libwine_unicode.so.1.0=0A=
Please clean up your patch or better yet specify the files you want diff'ed
cvs diff -u dlls/comctrl32/tab.c windows/sysparams.c > patch.txt
Index: dlls/comctl32/tab.c=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
RCS file: /home/wine/wine/dlls/comctl32/tab.c,v=0A=
retrieving revision 1.78=0A=
diff -u -r1.78 tab.c=0A=
--- dlls/comctl32/tab.c 17 Mar 2003 04:43:26 -0000 1.78=0A=
+++ dlls/comctl32/tab.c 23 Mar 2003 08:52:10 -0000=0A=
@@ -3075,7 +3075,7 @@=0A=
return 0;=0A=
=0A=
case TCM_SETPADDING:=0A=
- FIXME("Unimplemented msg TCM_SETPADDING\n");=0A=
+ TabCtrl_SetPadding (hwnd, wParam, lParam);=0A=
return 0;=0A=
=0A=
[snip]
Make sure your patch sure your patch is cleaned up (this is a NOOP and just makes the patch larger than nessarry)--- windows/win.c 14 Mar 2003 04:11:17 -0000 1.216=0A= +++ windows/win.c 23 Mar 2003 08:52:13 -0000=0A= @@ -2311,7 +2311,7 @@=0A= =0A= /* when window belongs to other process, don't send a message */=0A= if (nMaxCount <=3D 0) return 0;=0A= - get_server_window_text( hwnd, lpString, nMaxCount );=0A= + get_server_window_text( hwnd, lpString, nMaxCount ); =0A= return strlenW(lpString);=0A= }=0A= =0A=
Please resubmit your patch in the proper format.
--
Tony Lambregts
