Change Log: Clarify patch requirements
Files changed: documentation/patches.sgml
--
Tony Lambregts
Index: patches.sgml
===================================================================
RCS file: /home/wine/wine/documentation/patches.sgml,v
retrieving revision 1.6
diff -u -r1.6 patches.sgml
--- patches.sgml 18 Feb 2003 23:23:35 -0000 1.6
+++ patches.sgml 5 Mar 2003 21:44:49 -0000
@@ -48,8 +48,8 @@
</para>
<para>
For additions: mention that you have some new files and
- include them as either separate attachments or by appending
- the <command>diff -u /dev/null /my/new/file</command> output of them
+ include them by appending the
+ <command>diff -u /dev/null /my/new/file</command> output of them
to any <command>cvs diff -u</command> output you may have.
Alternatively, use <command>diff -Nu olddir/ newdir/</command>
in case of multiple new files to add.
@@ -80,8 +80,9 @@
<itemizedlist>
<listitem>
<para>
- No HTML mail please. It is considered bad netiquette as it uglifies
- the message, and is not viewable by many of the subscribers.
+ No HTML mail. Since patchs should be inlined and HTML turns the
+ patch into garbage. Also It is considered bad netiquette as it
+ uglifies the message, and is not viewable by many of the subscribers.
</para>
</listitem>
<listitem>
@@ -173,6 +174,15 @@
and using "Properties" verify the message source to make sure that
the mail has correct format. You might want to send several test
emails to yourself too.
+ </para>
+ </sect2>
+ <sect2 id="Alexandre-Bottom-Line">
+ <title>Alexandre's Bottom Line</title>
+ <para>
+ <quote>The basic rules are: no attachments, no mime crap, no
+ line wrapping, a single patch per mail. Basically if I can't
+ do <Command>"cat raw_mail | patch -p0"</command> it's in the
+ wrong format.</quote>
</para>
</sect2>
</sect1>
