On Wed, Dec 17, 2014 at 12:32:17PM +0100, Christophe Fergeau wrote:
> On Wed, Dec 17, 2014 at 12:24:06PM +0100, Fabiano Fidêncio wrote:
> > And do you think would be better/clearer than the way it is now?
>
> AC_SUBST will be substituted in Makefile.am, I think AC_DEFINE only gets
> defined in config.h. As Marc-André was pointing out, HAVE_LIBVIRT (and
> other HAVE_XXX vars that you use in your patches) are only set with
> AC_DEFINE and AM_CONDITIONAL, so I don't think using $(HAVE_LIBVIRT) as
> you are doing currently will do the right thing.
With 1/4 applied, make V=1 msi gives:
MANUFACTURER="Virt Manager Project" wixl -D SourceDir=/usr/x86_64-w64-mingw32/sys-root/mingw \
-D DESTDIR=$DESTDIR/usr/x86_64-w64-mingw32/sys-root/mingw \
-D GtkVersion=3.0 \
-D HaveLibvirt= \
--arch x64 \
-o virt-viewer-x64-2.0.msi \
virt-viewer.wxs virt-viewer-files.wxs && \
Note the empty value for -D HaveLibvirt
Christophe
Attachment:
pgpdagvRgROI4.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
