Re: [PATCH 1/4] msi: use libvirt conditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-12-17 at 12:20 +0100, Christophe Fergeau wrote:
> > > It's defined in the configure.ac, the same is valid for GTK_API_VERSION,
> > > HAVE_SPICE_GTK, HAVE_GTK_VNC and HAVE_OVIRT.
> > > IIRC I had problems using $(VAR) instead of $VAR or ${VAR}.
> > 
> > They are not defined the same way: AC_SUBST vs AC_DEFINE
> 
> Fwiw, there are AM_CONDITIONAL for each of the HAVE_XXX used in this
> series, something like
> if HAVE_LIBVIRT
>   WIXL_FLAGS += "-D HaveLibvirt=1"
> endif
> would probably work

And do you think would be better/clearer than the way it is now?


_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux