On Tue, Nov 27, 2012 at 04:32:02PM +0100, Christophe Fergeau wrote: > Hey, > > On Tue, Nov 27, 2012 at 03:17:48PM +0000, Richard W.M. Jones wrote: > > On Tue, Nov 27, 2012 at 05:07:59PM +0200, Zeeshan Ali (Khattak) wrote: > > > On Tue, Nov 27, 2012 at 5:04 PM, Richard W.M. Jones <rjones@xxxxxxxxxx> wrote: > > > > On Tue, Nov 27, 2012 at 04:12:10PM +0200, Zeeshan Ali (Khattak) wrote: > > > >> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> > > > >> > > > >> --- > > > >> data/oses/windows.xml.in | 2 +- > > > >> .../en_windows_8_enterprise_x86_dvd_917587.iso.txt | 29 ++++++++++++++++++++++ > > > >> 2 files changed, 30 insertions(+), 1 deletion(-) > > > >> create mode 100644 test/isodata/windows/win8/en_windows_8_enterprise_x86_dvd_917587.iso.txt > > > >> > > > >> diff --git a/data/oses/windows.xml.in b/data/oses/windows.xml.in > > > >> index 2a58d8d..851c1b7 100644 > > > >> --- a/data/oses/windows.xml.in > > > >> +++ b/data/oses/windows.xml.in > > > >> @@ -737,7 +737,7 @@ > > > >> > > > >> <media arch="i386"> > > > >> <iso> > > > >> - <volume-id>HB1_CCPA_X86FRE</volume-id> > > > >> + <volume-id>(HB1_CCPA_X86FRE)|(HRM_CENA_X86)</volume-id> > > > > > > > > Right .. as you guessed I downloaded the 32 bit ISO by accident :-( > > > > > > > > It's a bit unfortunate that libosinfo isn't distinguishing between > > > > different editions of the base OS (ie. Desktop vs Server vs > > > > BTW I meant to write "Client" instead of "Desktop" here. > > Windows calls all the consumer editions "Client". > > RHEL has a variant called "Desktop". > > > > > > Enterprise). > > > > > > We know of this issue and have plans to address it (I even have > > > half-baked patch). Just don't know whats the best approach: Separate > > > media entries for each variant or separate OS entries for each > > > variant? > > > > It's definitely more like a different OS than just different media. > > I think you are talking about 2 different things. Reading > http://libguestfs.org/guestfs.3.html#guestfs_inspect_get_product_variant , > what you ask for is about knowing that Win7 and Win2k8 are similar OSes, > but one is a consumer edition, the other one is aimed at servers. I think > what Zeeshan was talking about is about differentiating between the various > existing Win7 editions (Home, Professional, Enterprise, ...), see > https://en.wikipedia.org/wiki/Windows_7_editions for the full list. It looks like it. For libguestfs we need to variant as I described. We don't care about Editions. Although there is probably a mapping between "Editions" and the variant which is finally installed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list