Re: [PATCH v3] Add blkzonecmd and blkreport ZAC/ZBC drives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 17, 2017 at 09:12:29AM +0900, Damien Le Moal wrote:
> Benno,
> 
> On 2/16/17 21:15, Benno Schulenberg wrote:
> > 
> > On Thu, Feb 16, 2017, at 11:33, Karel Zak wrote:
> >>   blkzone report [--zone <offset>] [--count <length>]
> >>   blkzone reset  [--zone <offset>] [--count <length>]
> > 
> > "blkzone --zone" feels a bit strange.  I would suggest:
> > 
> >   blkzone <command> [--offset <sector>] [--count <number>]
> 
> Indeed, it is a little awkward. And to be consistent with other tools
> such as blkdiscard, I would also suggest --length instead of --count.
> 
> So:
> 
> blkzone report [--offset <offset>] [--length <length>]
> blkzone reset  [--offset <offset>] [--length <length>]

 blkzone(8) implemented, blkreset and blkreport removed. 

 Please, retest and review:
 https://github.com/karelzak/util-linux/blob/master/sys-utils/blkzone.c
 https://github.com/karelzak/util-linux/blob/master/sys-utils/blkzone.8

    Karel
-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux