Re: [PATCH 1/2] libmount: add mnt_fs_is_btrfs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 23, 2017 at 03:04:43PM +0100, Petr Vorel wrote:
>  libmount/docs/libmount-sections.txt |  1 +
>  libmount/src/fs.c                   | 11 +++++++++++
>  libmount/src/libmount.h.in          |  1 +
>  libmount/src/libmount.sym           |  7 ++++++-
>  4 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/libmount/docs/libmount-sections.txt b/libmount/docs/libmount-sections.txt
> index 78d89cae7..65f774c2c 100644
> --- a/libmount/docs/libmount-sections.txt
> +++ b/libmount/docs/libmount-sections.txt
> @@ -209,6 +209,7 @@ mnt_fs_get_usedsize
>  mnt_fs_get_userdata
>  mnt_fs_get_user_options
>  mnt_fs_get_vfs_options
> +mnt_fs_is_btrfs
>  mnt_fs_is_kernel
>  mnt_fs_is_netfs
>  mnt_fs_is_pseudofs
> diff --git a/libmount/src/fs.c b/libmount/src/fs.c
> index 1c4ba1aab..e1bb9cde4 100644
> --- a/libmount/src/fs.c
> +++ b/libmount/src/fs.c
> @@ -616,6 +616,17 @@ int mnt_fs_is_netfs(struct libmnt_fs *fs)
>  }
>  
>  /**
> + * mnt_fs_is_btrfs:
> + * @fs: filesystem
> + *
> + * Returns: 1 if the filesystem is a btrfs fs type
> + */
> +int mnt_fs_is_btrfs(struct libmnt_fs *fs)
> +{
> +	return !strcmp(fs->fstype, "btrfs");
> +}

 ???

 What's wrong with 

   strcmp(mnt_fs_get_fstype(fs, "btrfs"))

 why we need FS specific function exported by API?

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux