Forgot to attach the patches… -- Damien Le Moal, Ph.D. Sr. Manager, System Software Research Group, Western Digital Damien.LeMoal@xxxxxxx (+81) 0466-98-3593 (ext. 513593) 1 kirihara-cho, Fujisawa, Kanagawa, 252-0888 Japan www.wdc.com, www.hgst.com From: Damien Le Moal <Damien.LeMoal@xxxxxxx> Date: Friday, February 24, 2017 at 13:10 To: Karel Zak <kzak@xxxxxxxxxx> Cc: Benno Schulenberg <bensberg@xxxxxxxxxxxxx>, Shaun Tancheff <shaun@xxxxxxxxxxxx>, Util-Linux <util-linux@xxxxxxxxxxxxxxx>, Van Assche Bart <Bart.VanAssche@xxxxxxxxxxx> Subject: Re: [PATCH v3] Add blkzonecmd and blkreport ZAC/ZBC drives Karel, Please find attached 3 patches. 1) To be consistent with blkdiscard behavior, reset all zones of the device when length is not specified. 2) Similarly, for report, report all zones of the device is length is unspecified on the command line. 3) Improve wording to match more closely the standards. ALos add "0x" to printed values to make it clear that these are hex. Please review and let me know if you need more testing. Best regards. -- Damien Le Moal, Ph.D. Sr. Manager, System Software Research Group, Western Digital Damien.LeMoal@xxxxxxx (+81) 0466-98-3593 (ext. 513593) 1 kirihara-cho, Fujisawa, Kanagawa, 252-0888 Japan www.wdc.com, www.hgst.com From: Karel Zak <kzak@xxxxxxxxxx> Date: Friday, February 24, 2017 at 01:33 To: Damien Le Moal <Damien.LeMoal@xxxxxxx> Cc: Benno Schulenberg <bensberg@xxxxxxxxxxxxx>, Shaun Tancheff <shaun@xxxxxxxxxxxx>, Util-Linux <util-linux@xxxxxxxxxxxxxxx>, Van Assche Bart <Bart.VanAssche@xxxxxxxxxxx> Subject: Re: [PATCH v3] Add blkzonecmd and blkreport ZAC/ZBC drives On Fri, Feb 17, 2017 at 09:12:29AM +0900, Damien Le Moal wrote: Benno, On 2/16/17 21:15, Benno Schulenberg wrote: > > On Thu, Feb 16, 2017, at 11:33, Karel Zak wrote: >> blkzone report [--zone <offset>] [--count <length>] >> blkzone reset [--zone <offset>] [--count <length>] > > "blkzone --zone" feels a bit strange. I would suggest: > > blkzone <command> [--offset <sector>] [--count <number>] Indeed, it is a little awkward. And to be consistent with other tools such as blkdiscard, I would also suggest --length instead of --count. So: blkzone report [--offset <offset>] [--length <length>] blkzone reset [--offset <offset>] [--length <length>] blkzone(8) implemented, blkreset and blkreport removed. Please, retest and review: https://github.com/karelzak/util-linux/blob/master/sys-utils/blkzone.c https://github.com/karelzak/util-linux/blob/master/sys-utils/blkzone.8 Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com
Attachment:
0001-blkzone-Reset-all-zones-when-length-is-not-specified.patch
Description: 0001-blkzone-Reset-all-zones-when-length-is-not-specified.patch
Attachment:
0002-blkzone-Report-all-zones-if-length-is-not-specified.patch
Description: 0002-blkzone-Report-all-zones-if-length-is-not-specified.patch
Attachment:
0003-blkzone-Improve-zone-information-print.patch
Description: 0003-blkzone-Improve-zone-information-print.patch
