Re: Pull request: nsenter(1) fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 07, 2016 at 08:34:13PM +0100, Ruediger Meier wrote:
> On Tuesday 06 December 2016, Karel Zak wrote:
> > On Mon, Dec 05, 2016 at 01:27:11PM -0500, J William Piggott wrote:
> > > On 12/05/2016 06:51 AM, Karel Zak wrote:
> > > > On Mon, Dec 05, 2016 at 11:25:45AM +0100, Michael Kerrisk 
> (man-pages) wrote:
> > > >> I have various fixes to send, but I'll start small, with a
> > > >> couple of fixes for nsenter(1).
> > > >
> > > >  Applied ... but you have removed "See also.. " sentence from
> > > >  description of the --user. Would be better to keep there?
> > > >
> > > >> Is a git pull request compatible with your
> > > >> workflow?
> > > >
> > > >  Sure.
> > >
> > > Does this apply to all of us? We no longer need to submit patches
> > > to the mailing list for peer review?
> >
> > Well, send patch to the mailing list for review is always good
> > choice, and it's definitely wanted for invasive or sensitive things,
> > or if you're not sure.
> >
> > I think for trivial changes where is nothing to discuss it's probably
> > good enough to send pull request only.
> >
> > It's also good idea to keep the latest version of your patches in
> > public remote repository (e.g. github) if you expect any additional
> > changes after review etc.
> >
> >
> > Use common sense anyway. It works better than strict rules.
> 
> One thing I would really like is that you would merge the mailing list 
> patch-sets in the same way like github does, using "git merge --no-ff". 
> This always adds an explicit merge commit which makes IMO later review 
> and bisecting easier. (Less uninteresting/intermediate points in 
> master.)

I use "git pull --log <url>" for remote repositories and "git-am" for emails.

I have doubts "git-am" allows to work with emails as with branch. IMHO
it will require manual intervention and apply the patches from mailbox
to the separate temporary branch and then merge the branch. The
question is also where to start the branch for the emails, it seems
there is no reliable information about a parental commit in the emails.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux