Re: Pull request: nsenter(1) fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 05, 2016 at 01:27:11PM -0500, J William Piggott wrote:
> On 12/05/2016 06:51 AM, Karel Zak wrote:
> > On Mon, Dec 05, 2016 at 11:25:45AM +0100, Michael Kerrisk (man-pages) wrote:
> >> I have various fixes to send, but I'll start small, with a couple of
> >> fixes for nsenter(1).
> > 
> >  Applied ... but you have removed "See also.. " sentence from
> >  description of the --user. Would be better to keep there?
> > 
> >> Is a git pull request compatible with your
> >> workflow?
> > 
> >  Sure. 
> 
> Does this apply to all of us? We no longer need to submit patches to the
> mailing list for peer review?

Well, send patch to the mailing list for review is always good choice,
and it's definitely wanted for invasive or sensitive things, or if
you're not sure.

I think for trivial changes where is nothing to discuss it's probably
good enough to send pull request only.

It's also good idea to keep the latest version of your patches in
public remote repository (e.g. github) if you expect any additional
changes after review etc. 


Use common sense anyway. It works better than strict rules. 


And this is not LKML, this is mailing list where we keep things in
friendly atmosphere, so don't be afraid to make a bad choice,
contribute non-perfect solution or ask "stupid" questions...

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux