On Thursday 03 November 2016, Karel Zak wrote: > On Wed, Nov 02, 2016 at 11:11:42PM +0100, Bernhard Voelker wrote: > > On 11/02/2016 04:51 PM, Karel Zak wrote: > > >> +timeout 1s bash -c "while [ \$(ps --ppid $pid |wc -l) -lt 2 ]; > > >> do sleep 0.1 ;done" \ > > > > > > is "0.1" portable? :-) > > > > if one has timeout from coreutils, then it's likely that she also > > has sleep from there. Thus said, I'd rather worry about > > portability of using timeout rather than the "0.1" (if sleep fails, > > then nobody will care anyway). ;-) > > Good point... I have added check for "timeout". BTW we have already a lot more coreutils and other GNU dependencies in our tests, inclusive timeout and sleep for floats. AFAIR for v2.28 I had fixed all GNU deps for configure/make but for the test-suite it was too painful. The OSX build on travis needs for the tests at least GNU readlink, seq, truncate, find, xargs, tar and sed. The Linux-only tests have even more coreutils deps. To replace sleep for floats, we could check and use usleep(1) from sysvinit. Or we could even add usleep to util-linux as we did with other sysvinit commands. cu, Rudi -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
