On Tue, Jul 10, 2012 at 12:08:25PM +0200, Karel Zak wrote:
> On Sat, Jun 30, 2012 at 10:59:11PM +0200, Sami Kerola wrote:
> > > is this last case just so you can AC_DEFINE the value below ? in general,
> > > this is fragile. defines should be expanded at make time rather than configure.
> > >
> > > CPPFLAGS="$CPPFLAGS -D_PATH_LOCALSTATEDIR=\"\${localstatedir}\""
>
> Good point.
>
> > The comment was a bit mysterious to me, so I tried to find what you
> > meant by fragility. The
> >
> > http://www.opensource.apple.com/source/xar/xar-28/xar/configure.ac
> >
> > has following
> >
> > dnl Define cpp macros in CPPFLAGS, rather than doing AC_DEFINE(macro), since the
> > dnl definitions need to be seen before and headers are included, which is a pain
> > dnl to make happen otherwise.
> >
> > which seem to match what you meant. I changed the line to be C
> > preprocessor definition, and added you as patch CC. Benno, I added you
> > to swapon patches CC as well. The changes are in my git.
>
> Please, don't use #include "config.h" at all. It's unnecessary,
> because -D_PATH_LOCALSTATEDIR and it's also necessary because we use
> -include "config.h" on compiler command line -- both is evaluated
> before regular "#include".
>
>
> I'm also not sure about
>
> /var/lib/libuuid/clock.txt --> /run/libuuid/clock.txt
>
> rename, the /var/lib is persistent...
Oh.. you have moved the file to /run/uuidd, that's really bad place.
The file is used by libbuid library. (In Fedora we have bug in
util-linux.spec file, the file should be owned by libuuid rather than
by uuidd.)
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
