On Fri, Jun 29, 2012 at 5:38 AM, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
> On Wednesday 27 June 2012 17:33:25 Sami Kerola wrote:
>> --- a/configure.ac
>> +++ b/configure.ac
>>
>> +case $prefix:$localstatedir in
>> + NONE:'${prefix}/var')
>> + localstatedir=/run
>> + AC_MSG_NOTICE([ --localstatedir defaults to /run])
>
> i'd trim the leading whitespace in the message
Why? It looks correct to me.
$ ./configure
[...]
configure: Default --exec-prefix detected.
configure: --bindir defaults to /bin
configure: --sbindir defaults to /sbin
configure: --libdir defaults to /lib
configure: --localstatedir defaults to /run
[...]
>> + ;;
>> + *:'${prefix}/var')
>> + localstatedir=${prefix}/run
>> + ;;
>> + NONE:*)
>> + ;;
>> + *:*)
>> + localstatedir=${prefix}/${localstatedir}
>> + ;;
>> +esac
>
> is this last case just so you can AC_DEFINE the value below ? in general,
> this is fragile. defines should be expanded at make time rather than configure.
>
> CPPFLAGS="$CPPFLAGS -D_PATH_LOCALSTATEDIR=\"\${localstatedir}\""
The comment was a bit mysterious to me, so I tried to find what you
meant by fragility. The
http://www.opensource.apple.com/source/xar/xar-28/xar/configure.ac
has following
dnl Define cpp macros in CPPFLAGS, rather than doing AC_DEFINE(macro), since the
dnl definitions need to be seen before and headers are included, which is a pain
dnl to make happen otherwise.
which seem to match what you meant. I changed the line to be C
preprocessor definition, and added you as patch CC. Benno, I added you
to swapon patches CC as well. The changes are in my git.
git://github.com/kerolasa/lelux-utiliteetit.git varrun-swapon
AFAIK the last thing to sort out before merge is the lsblk & swapon
device size difference. Either I did something silly, or there is some
sort of issue somewhere.
--
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
