Re: [pull] /run directory and swapon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 27 June 2012 17:33:25 Sami Kerola wrote:
> --- a/configure.ac
> +++ b/configure.ac
> 
> +case $prefix:$localstatedir in
> +  NONE:'${prefix}/var')
> +    localstatedir=/run
> +    AC_MSG_NOTICE([  --localstatedir defaults to /run])

i'd trim the leading whitespace in the message

> +    ;;
> +  *:'${prefix}/var')
> +    localstatedir=${prefix}/run
> +    ;;
> +  NONE:*)
> +    ;;
> +  *:*)
> +    localstatedir=${prefix}/${localstatedir}
> +    ;;
> +esac

is this last case just so you can AC_DEFINE the value below ?  in general, 
this is fragile.  defines should be expanded at make time rather than configure.

CPPFLAGS="$CPPFLAGS -D_PATH_LOCALSTATEDIR=\"\${localstatedir}\""
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux