On Mon, Jan 31, 2011 at 05:12:06PM +0100, Fabian Groffen wrote: > On 31-01-2011 16:53:49 +0100, Karel Zak wrote: > > > I'll apply this patch after 2.19 release. We have to check that > > > <err.h> does not conflict with any locally defined err() or warn() > > > function or variable. > > > > ... or move all the fallback solution to other file than c.h, for > > example "ulerr.h", and include this file instead of <err.h>. > > Hmmm, what's the difference? The fallbacks are only defined when err.h c.h is included almost everywhere, but currently <err.h> is included only on places where we need err() or warn() or so. For example fdisk/sfdisk.c includes c.h, but has private warn() implementation. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html