Re: [PATCH] provide alternatives for err, errx, warn and warnx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 21, 2011 at 09:16:30PM +0100, Fabian Groffen wrote:
> +noinst_LTLIBRARIES = libreplace.la
> +libreplace_la_SOURCES = err.c

 I'm not sure that libreplace.la is an ideal solution. Our build
 system allows to define different CFLAGS and LDFLAGS for suid
 utils. (And use libtool for almost all utils sounds crazy.)

 The lib/err.c should not be compiled on systems with proper err, errx
 warn and warx functions. 
 
 Please, use an AM_CONDITIONAL and conditionally define
 $(ul_err_fallback) in config/include-Makefile.am, then use
 
    foo_SOURCES = foo.c $(ul_err_fallback) 
    
 in the others Makefile.am files -- such implementation will have no
 impact to compiling on systems with uClib/glibc.
 
    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux