Re: [PATCH 1/2] mkswap: fixed strtoll() usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le mardi 30 mars 2010 à 20:17 +0200, Karel Zak a écrit :
> On Tue, Mar 30, 2010 at 05:17:56PM +0200, Yann Droneaud wrote:
> > - catch empty string
> > - check against LLONG_MAX and LLONG_MIN instead of ULLONG_MAX and 0
> > 
> > Signed-off-by: Yann Droneaud <yann@xxxxxxxxxxx>
> 
>  Applied, thanks (for patience;-)
> 

You're welcome.

strto{u}l{l}() is quite hard to use. Reading your patch teach me another
thing about strtoul{l}(): numbers starting with a minus sign are valid
unsigned values ... First I didn't believe and thought you were wrong,
then I've wrote a test program, wondering about a glibc bug. Ultimately
I've double check against Opengroup specifications. In the end, I must
admit that -1 is a valid unsigned number ... quite weird if you ask
me :)

Regards.

-- 
Yann Droneaud



--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux