Re: [PATCH] mount: make the --offset option support hex number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



You've made little mistakes in your fixes to mount and mkswap:
- one must check that endptr doesn't match the string pointer to convert
  otherwise empty string will be accepted as correct (eg *str == '\0', so
  if endptr == str, *endptr == '\0'). 
- when using strtoll(), overflow must be check against LLONG_MIN and LLONG_MAX.

Please apply the following patches.

Regards.

Yann Droneaud (2):
  mkswap: fixed strtoll() usage
  mount: fixed strtoll() usage

 disk-utils/mkswap.c |    5 +++--
 mount/mount.c       |   18 +++++++++++-------
 2 files changed, 14 insertions(+), 9 deletions(-)

-- 
Yann Droneaud
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux