On Tue, Mar 30, 2010 at 05:17:55PM +0200, Yann Droneaud wrote:
> You've made little mistakes in your fixes to mount and mkswap:
> - one must check that endptr doesn't match the string pointer to convert
if ((endptr && *endptr) ||
is enough, because endptr == str means that endptr is not empty
> otherwise empty string will be accepted as correct (eg *str == '\0', so
> if endptr == str, *endptr == '\0').
> - when using strtoll(), overflow must be check against LLONG_MIN and LLONG_MAX.
xnum < 0)
is enough, because LLONG_MIN is smaller than zero.
> Please apply the following patches.
Anyway, I have replaced the strtoll() with strtosize() in mount(8)
too. So mount(8) is compatible with losetup now.
> disk-utils/mkswap.c | 5 +++--
> mount/mount.c | 18 +++++++++++-------
Thanks for review!
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
