On Wed, Sep 23, 2009 at 01:00:17AM +0300, Maxim Levitsky wrote:
> @@ -111,6 +111,8 @@ static int probe_iso9660(blkid_probe pr, const struct blkid_idmag *mag)
> memcmp(iso->escape_sequences, "%/C", 3) == 0 ||
> memcmp(iso->escape_sequences, "%/E", 3) == 0) {
>
> + blkid_probe_set_version(pr, "Joliet Extension");
> +
> /* Is the Joliet (UTF16BE) label equal to the label in
> * the PVD? If yes, use PVD label. The Jolied version
> * of the label could be trimed (because UTF16..).
> @@ -123,7 +125,6 @@ static int probe_iso9660(blkid_probe pr, const struct blkid_idmag *mag)
> sizeof(iso->volume_id),
> BLKID_ENC_UTF16BE);
>
> - blkid_probe_set_version(pr, "Joliet Extension");
> goto has_label;
> }
> off += ISO_SECTOR_SIZE;
>
> Otherwise blkid doesn't announce the filesystem version
Applied, thanks.
> (anybody uses that?)
Maybe some GUI applications.
> Is there a benefit to detect rock-ridge extension as well?
Probably yes, it would be nice to have all important information
about filesystems. There is also "El Torito" extension for bootable
CD-ROMs.
I'm not sure if VERSION= for Joliet and Rock-Ridge makes sense,
it might be better to add a new value EXTENSIONS=<list>, for example
EXTENSIONS=Joliet,Rock-Ridge
for hybrid CD-ROMs.
The VERSION= value should be probably based on vd_version from PVD.
The other interesting information is mode (1, 2 (audio, ...)).
(CC: to davidz how is our gateway to the desktop world :-)
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
