On Tue, 2009-09-22 at 20:08 +0200, Karel Zak wrote:
> On Tue, Sep 22, 2009 at 05:20:33PM +0300, Maxim Levitsky wrote:
> > I don't yet see this patch (and the one that will fix joliet label
> > usage) in the public repository at:
>
> Sorry, pushed.
>
> Karel
>
Thanks!
Just one minor nitpick, you probably want to call the
"blkid_probe_set_version(pr, "Joliet Extension");" anyway, something
like that:
@@ -111,6 +111,8 @@ static int probe_iso9660(blkid_probe pr, const struct blkid_idmag *mag)
memcmp(iso->escape_sequences, "%/C", 3) == 0 ||
memcmp(iso->escape_sequences, "%/E", 3) == 0) {
+ blkid_probe_set_version(pr, "Joliet Extension");
+
/* Is the Joliet (UTF16BE) label equal to the label in
* the PVD? If yes, use PVD label. The Jolied version
* of the label could be trimed (because UTF16..).
@@ -123,7 +125,6 @@ static int probe_iso9660(blkid_probe pr, const struct blkid_idmag *mag)
sizeof(iso->volume_id),
BLKID_ENC_UTF16BE);
- blkid_probe_set_version(pr, "Joliet Extension");
goto has_label;
}
off += ISO_SECTOR_SIZE;
Otherwise blkid doesn't announce the filesystem version (anybody uses that?)
Is there a benefit to detect rock-ridge extension as well?
Best regards,
Maxim Levitsky
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
