On Tue, 2009-09-22 at 15:22 +0200, Karel Zak wrote: > Hi Maxim, > > On Tue, Sep 22, 2009 at 04:48:03AM +0300, Maxim Levitsky wrote: > > > However blkid_probe_set_label removes this whitespace, but > > > blkid_probe_set_utf8label don't. > > you're right. This is a bug. > > > > Attached patch (against -git) just adds the whitespace removal to second > > > function. > > I have committed a little different version (see below). > > Please, use the "Signed-off-by:" line in your patches next time. For > more details see README.devel in the package. Thanks. Sure! I thought that only the kernel developers use 'Signed-off-by:" Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx> > > > However there is additional problem, > > Problem is that Joliet label is saved in UTF-16, thus consists only of > > 16 chars, while, normal label is 32 chars wide. > > > What you suggest to do? > > The old good libvolume_id had a nice solution. Unfortunately, I have > forgot to port this solution to libblkid. It should be fixed now (see > u-l-ng repository). > > > Is that this important to use joilet label? > > We need to use Joliet label if the label is different to the label > from (ISO9660) primary volume descriptor. > > It means that ASCII-only label should be always read from ISO9660 > primary volume descriptor, because this label is longer (32 chars). > The Joliet label (16 chars) should be used for non-ASCII chars only. > > Thanks, we fix two bugs ;-) Thanks. I don't yet see this patch (and the one that will fix joliet label usage) in the public repository at: git://git.kernel.org/pub/scm/utils/util-linux-ng/util-linux-ng.git Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
