On Wednesday 05 December 2007, Stepan Kasal wrote:
> On Tue, Dec 04, 2007 at 07:25:28PM -0500, Mike Frysinger wrote:
> > > +# OTOH, the following two has little chance to succeed; please specify
> > > the +# right values on the configure command-line:
> > > +#
> > > +: ${BLKID_LIBS_STATIC='$(BLKID_LIBS)'}
> > > +: ${VOLUMEID_LIBS_STATIC='$(VOLUMEID_LIBS)'}
> >
> > # comments should not be used in m4 code. use dnl.
>
> Indeed, dnl denotes m4 comments, which are not written to the output.
>
> I wrote shell comments, because the were meant to be stored in the
> resulting configure script. The idea was that since the static build
> won't work by default, the user will then grep for BLKID_LIBS_STATIC
> to find out what went wrong. And if they search configure instead of
> configure.ac, the hint is readily available there.
fair enough
> > this structure isnt portable shell:
> > : ${VAR='foo'}
>
> I am not aware about any problems with this construct and I was not
> able to find anything about it in the Autoconf manual.
>
> Would you be so kind as to refer me to a documentation which explains
> what's wrong with this?
i dont have any documentation to back up my claim, just code. ive never seen
this construct in autoconf generated code and flipping through some configure
scripts, all i can find are places using the ${var+set} form to setup default
values.
especially considering this:
- older automake used the form
: ${VAR='foo'}
- newer automake switched same code base to use
test "${VAR+set}" = set || VAR="foo"
> > besides, what's with these magic variables existing at all ? they should
> > get properly discovered via pkg-config scripts, not randomly hardcoded
>
> That's what Karel originally had in his patch. Unfortunately, I
> discovered a problem with pkg-config, so I decided to leave the
> introduction of pkg-config for a future patch.
could you elaborate ? if there's a bug in say pkg-config.m4, i think it's
reasonable for us to include a fixed version until the latest pkg-config
upstream gets fixed ...
-mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
