Hello,
On Tue, Dec 04, 2007 at 07:25:28PM -0500, Mike Frysinger wrote:
> > +# OTOH, the following two has little chance to succeed; please specify the
> > +# right values on the configure command-line:
> > +#
> > +: ${BLKID_LIBS_STATIC='$(BLKID_LIBS)'}
> > +: ${VOLUMEID_LIBS_STATIC='$(VOLUMEID_LIBS)'}
>
> # comments should not be used in m4 code. use dnl.
Indeed, dnl denotes m4 comments, which are not written to the output.
I wrote shell comments, because the were meant to be stored in the
resulting configure script. The idea was that since the static build
won't work by default, the user will then grep for BLKID_LIBS_STATIC
to find out what went wrong. And if they search configure instead of
configure.ac, the hint is readily available there.
I rigidly use dnl comments when speaking about m4 macros; then the
comment has not sense in the expanded shell script. But when
commenting an actual shell code, I always consider the possibility to
use `#' instead of dnl.
If Karel does not want to have these comments in the expanded
configure script, he can replace them with a dnl comment and/or add
a hint to an appropriate place.
> this structure isnt portable shell:
> : ${VAR='foo'}
I am not aware about any problems with this construct and I was not
able to find anything about it in the Autoconf manual.
Would you be so kind as to refer me to a documentation which explains
what's wrong with this?
> besides, what's with these magic variables existing at all ? they should get
> properly discovered via pkg-config scripts, not randomly hardcoded
That's what Karel originally had in his patch. Unfortunately, I
discovered a problem with pkg-config, so I decided to leave the
introduction of pkg-config for a future patch.
> [...] and undocumented for users.
You are right, I should have used AC_ARG_VAR to document these
variables.
Thank you for your comment.
I'll prepare an improved version of the patch.
Have a nice day,
Stepan Kasal
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
