Re: [PATCH] build-sys: add --enable-static-programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 04 December 2007, Stepan Kasal wrote:
> +dnl Static compilation
> +AC_ARG_ENABLE([static-programs],
> +  [AS_HELP_STRING([--enable-static-programs=LIST],
> +      [link static the programs in LIST (comma-separated,
> +      supported for losetup, mount, umount, fdisk, sfdisk)])])

the LIST should be optional so that people can specify all of them with:
--enable-static-programs

> +# These default values should work in most cases:
> +: ${BLKID_LIBS='-lblkid -luuid'}
> +: ${VOLUMEID_LIBS='-lvolume_id'}
> +
> +# OTOH, the following two has little chance to succeed; please specify the
> +# right values on the configure command-line:
> +#
> +: ${BLKID_LIBS_STATIC='$(BLKID_LIBS)'}
> +: ${VOLUMEID_LIBS_STATIC='$(VOLUMEID_LIBS)'}

# comments should not be used in m4 code.  use dnl.

this structure isnt portable shell:
: ${VAR='foo'}

besides, what's with these magic variables existing at all ?  they should get 
properly discovered via pkg-config scripts, not randomly hardcoded and 
undocumented for users.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux