Re: [PATCH] build-sys: add --enable-static-programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 04, 2007 at 07:25:28PM -0500, Mike Frysinger wrote:
> On Tuesday 04 December 2007, Stepan Kasal wrote:
> > +dnl Static compilation
> > +AC_ARG_ENABLE([static-programs],
> > +  [AS_HELP_STRING([--enable-static-programs=LIST],
> > +      [link static the programs in LIST (comma-separated,
> > +      supported for losetup, mount, umount, fdisk, sfdisk)])])
> 
> the LIST should be optional so that people can specify all of them with:
> --enable-static-programs

 Good idea.

> > +# These default values should work in most cases:
> > +: ${BLKID_LIBS='-lblkid -luuid'}
> > +: ${VOLUMEID_LIBS='-lvolume_id'}
> > +
> > +# OTOH, the following two has little chance to succeed; please specify the
> > +# right values on the configure command-line:
> > +#
> > +: ${BLKID_LIBS_STATIC='$(BLKID_LIBS)'}
> > +: ${VOLUMEID_LIBS_STATIC='$(VOLUMEID_LIBS)'}
> 
> # comments should not be used in m4 code.  use dnl.

 Hmm, aclocal.m4 is full of '#'. But I agree we should be consistent
 with the rest of configure.ac.

> this structure isnt portable shell:
> : ${VAR='foo'}

 Stepan?


-- 
 Karel Zak  <kzak@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux