On Thu, Oct 04, 2007 at 02:28:58PM +0200, Ludwig Nussel wrote: > Karel Zak wrote: > > On Wed, Aug 29, 2007 at 01:23:42PM -0600, LaMont Jones wrote: > > > On Wed, Aug 29, 2007 at 03:25:35PM +0200, Ludwig Nussel wrote: > > > > Fine with me. I doubt that removing -N would hurt the debian user > > > > base though. I guess noone sane would deliberately use that option. > > > > > > The only place I could see someone using it would be if they were > > > mounting a volume they had built elsewhere (or were using elsewhere), > > > and hadn't rebuilt yet/couldn't rebuild. > > > > > > Here's the patch with -N dropped, which is fine by me. > > > > At first glance this patch seems OK. I assume some negative feedbacks > > from lkml people who hate cryptoloop :-) So.. some questions: > > > > * how many distributions already support in-losetup hashes? > > (Suse, Debian, ?) > > > > * the original idea was: hashprog | losetup -p0 .... > > IIRC won't work as losetup doesn't really expect a binary stream > there (stops reading on \n). Yes, I know :-( > > > Incompatible change: > > > Default is now to hash using sha512. Debian users will need > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Why? Why not 'none'? > > A passphrase is too weak for direct use as encryption key. The > default certainly should not encourage that. > http://en.wikipedia.org/wiki/Key_strengthening Well, there is something like key strengthening hash(key) + hash('A' + key) for rmd160 only. The others hash functions are simple "text" --> "hash" transformation only. I don't see iterations, salt or whatever ;-( Diffstat: 11 files changed, 1207 insertions(+), 49 deletions(-) I understand that you want to see some things upstream, but ... the cryptoloop is deprecated and I'd like to fix bugs in deprecated stuff only. Sorry, I'm really don't think we need it in upstream code. Karel -- Karel Zak <kzak@xxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
