Karel Zak wrote:
> Well, there is something like key strengthening
>
> hash(key) + hash('A' + key)
>
> for rmd160 only. The others hash functions are simple "text" --> "hash"
> transformation only. I don't see iterations, salt or whatever ;-(
The above method is just needed for rmd160 as it produces only a
20byte key whereas typically a 32bit one is needed. The loop-AES
patch did suppport iterations (with AES) and salt. I don't those
options where actually used too much though so I omitted them from
the consolidated patch.
> Diffstat:
>
> 11 files changed, 1207 insertions(+), 49 deletions(-)
>
> I understand that you want to see some things upstream, but ... the
> cryptoloop is deprecated and I'd like to fix bugs in deprecated stuff
> only.
>
> Sorry, I'm really don't think we need it in upstream code.
For SUSE and Debian this patch is kind of mandatory so customers can
still conveniently access their existing volumes. As long as the
kernel doesn't drop cryptoloop I don't see a reason to drop proper
userspace support for it either. So even if you don't want to
integrate the patch please at least don't reuse it's command line
options. I'd also remove references to the -e option from the
upstream losetup man page so people don't accidently use it.
cu
Ludwig
--
(o_ Ludwig Nussel
//\
V_/_ http://www.suse.de/
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
