On Mon, 8 Oct 2007 14:07:42 -0400 Mike Frysinger wrote: > > And if mangle() just takes a "char *", casts are still needed, aren't they? > > no, because the buffers would also be char * OK, this is clearly better. Thanks. --- From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> Fix gcc warnings from: (try compilation with "-Wall -Wp,-D_FORTIFY_SOURCE=2") mount_mntent.c:28: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness mount_mntent.c:129: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness mount_mntent.c:130: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness mount_mntent.c:131: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness mount_mntent.c:132: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> --- mount/mount_mntent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- util-linux-ng-2.13.orig/mount/mount_mntent.c +++ util-linux-ng-2.13/mount/mount_mntent.c @@ -21,7 +21,7 @@ static unsigned char need_escaping[] = { ' ', '\t', '\n', '\\' }; static char * -mangle(const unsigned char *s) { +mangle(const char *s) { char *ss, *sp; int n; - To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html