On Thu, Jun 18, 2020 at 09:08:01PM +0200, Daniel Glöckner wrote: > Am 17.06.20 um 21:54 schrieb Sascha Hauer: > > Another option would be to put calling of fastboot_download_finished() > > into a workqueue, or just open code it as your original series did. > > ... now I understand that by "open code it" you are referring to calling > net_poll! By "open code" I meant that the functionality of fastboot_download_finished() was duplicated in the fastboot net code, but this was never the case. It seems my memory tricked me. > > I would have tried to run everything from fastboot_poll in a workqueue. > Since worklets are not reordered, splitting fastboot_poll into two worklets > might make sense. The worklet for calling fastboot_download_finished is > queued when fastboot_handle_type_fastboot sets active_download to false and > the worklet for the command execution is queued, as you implemented it, when > a new command arrives. I gave it a try and it was easy enough to implement, so we can drop this patch. Regards, Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
