Re: [PATCH 14/19] fastboot: remove double print

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sascha,

Am 17.06.20 um 10:11 schrieb Sascha Hauer:
> In fastboot UDP we can't send two messages without waiting for an ack
> from the host in between. Do not send two messages directly after each
> other in fastboot_download_finished() to make it safe to be called from
> the fastboot UDD code.

UDD -> UDP?

I see no reason for this patch. When this function is called, we have just
managed to transfer a file where every data packet was sent only after the
host has received our ack for the previous packet. And now you fear that the
host won't ack our next packet?

The fastboot UDP code in U-Boot was designed to send only a single message
for every executed command because it doesn't have code that waits for a
packet from the host when necessary. I think we should be proud that Barebox
can handle that case.

Best regards,

  Daniel


-- 
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke
Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux