Re: [PATCH 14/19] fastboot: remove double print

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 17.06.20 um 21:54 schrieb Sascha Hauer:
> Another option would be to put calling of fastboot_download_finished()
> into a workqueue, or just open code it as your original series did.

... now I understand that by "open code it" you are referring to calling
net_poll!

I would have tried to run everything from fastboot_poll in a workqueue.
Since worklets are not reordered, splitting fastboot_poll into two worklets
might make sense. The worklet for calling fastboot_download_finished is
queued when fastboot_handle_type_fastboot sets active_download to false and
the worklet for the command execution is queued, as you implemented it, when
a new command arrives.

Best regards,

  Daniel

-- 
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke
Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux