On 3/25/20 10:29 AM, Sascha Hauer wrote: > On Mon, Mar 23, 2020 at 11:31:26AM +0100, Ahmad Fatoum wrote: >> Hi, >> >> On 3/23/20 11:21 AM, Clément Leger wrote: >>>> AFAIK the device_type = "memory" property was mandatory in the early >>>> days as well, there shouldn't be any /memory nodes without this >>>> property. Given that, is the add-legacy-node-first still necessary? >>> >>> Agreed, I did that after speaking with someone on IRC which stated >>> (rightfully), that I should keep the legacy behavior if possible. >> >> My concern was about HW that passes a device tree to barebox (PowerPC >> possibly?), where it might have worked before and now won't anymore. >> >> If this is no real concern, it can be removed. > > There is no PowerPC hardware supported by barebox that passes a device > tree to barebox. I don't think this is necessary. Turns out we had quite a few device trees that lacked a device_type = "memory" property: https://lists.infradead.org/pipermail/barebox/2020-June/042269.html The property used to be there, but when upstream removed skeleton.dtsi and either there was no upstream memory node to extend or it was renamed, we ended up with an invalid memory node. > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
