Re: [PATCH 01/23] ARM: zii-common: Gate rdu_i210_invm() call with CONFIG_PCI_IMX6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 31, 2020 at 11:47:00AM -0700, Andrey Smirnov wrote:
> There's no reason to have rdu_i210_invm() inicalli if CONFIG_PCI_IMX6
> is not selected. Add appropriate ifdef to handle that.

Either this is the wrong way round...

> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
>  arch/arm/boards/zii-common/board.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boards/zii-common/board.c b/arch/arm/boards/zii-common/board.c
> index 7bd3a6cab..08e2f8b9b 100644
> --- a/arch/arm/boards/zii-common/board.c
> +++ b/arch/arm/boards/zii-common/board.c
> @@ -104,6 +104,8 @@ static int rdu_networkconfig(void)
>  }
>  late_initcall(rdu_networkconfig);
>  
> +#ifdef CONFIG_PCI_IMX6

...or this should be #ifndef

Sascha

> +
>  #define I210_CFGWORD_PCIID_157B		0x157b1a11
>  static int rdu_i210_invm(void)
>  {
> @@ -136,3 +138,5 @@ static int rdu_i210_invm(void)
>  	return 0;
>  }
>  late_initcall(rdu_i210_invm);
> +
> +#endif
> -- 
> 2.21.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux