On Tue, Mar 31, 2020 at 10:20 PM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
>
> On Tue, Mar 31, 2020 at 11:47:00AM -0700, Andrey Smirnov wrote:
> > There's no reason to have rdu_i210_invm() inicalli if CONFIG_PCI_IMX6
> > is not selected. Add appropriate ifdef to handle that.
>
> Either this is the wrong way round...
>
Hmm, not sure I understand what you mean. I210 card and its INVM won't
appear if PCIe is not enabled, that's why there's no reason to have
rdu_i210_invm() initcall if CONFIG_PCI_IMX6 is _not_ selected. Did I
miss something?
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> > ---
> > arch/arm/boards/zii-common/board.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boards/zii-common/board.c b/arch/arm/boards/zii-common/board.c
> > index 7bd3a6cab..08e2f8b9b 100644
> > --- a/arch/arm/boards/zii-common/board.c
> > +++ b/arch/arm/boards/zii-common/board.c
> > @@ -104,6 +104,8 @@ static int rdu_networkconfig(void)
> > }
> > late_initcall(rdu_networkconfig);
> >
> > +#ifdef CONFIG_PCI_IMX6
>
> ...or this should be #ifndef
>
> Sascha
>
> > +
> > #define I210_CFGWORD_PCIID_157B 0x157b1a11
> > static int rdu_i210_invm(void)
> > {
> > @@ -136,3 +138,5 @@ static int rdu_i210_invm(void)
> > return 0;
> > }
> > late_initcall(rdu_i210_invm);
> > +
> > +#endif
> > --
> > 2.21.0
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/barebox
> >
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
