Re: [PATCH 04/23] ARM: zii-common: Check for I2C errors in do_rdu2_switch_reset()

[Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>]

On Tue, Mar 31, 2020 at 11:47:03AM -0700, Andrey Smirnov wrote:
> ---
>  arch/arm/boards/zii-common/switch-cmd.c | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)

Missing Signed-off-by:

Sascha

> 
> diff --git a/arch/arm/boards/zii-common/switch-cmd.c b/arch/arm/boards/zii-common/switch-cmd.c
> index 2b9c34bfa..5e39d8fc6 100644
> --- a/arch/arm/boards/zii-common/switch-cmd.c
> +++ b/arch/arm/boards/zii-common/switch-cmd.c
> @@ -19,6 +19,7 @@
>  static int do_rdu2_switch_reset(void)
>  {
>  	struct i2c_client client;
> +	int ret;
>  	u8 reg;
>  
>  	client.adapter = i2c_get_adapter(1);
> @@ -29,12 +30,25 @@ static int do_rdu2_switch_reset(void)
>  	client.addr = 0x38;
>  	reg = 0x78;
>  	/* set switch reset time to 100ms */
> -	i2c_write_reg(&client, 0x0a, &reg, 1);
> +
> +	ret = i2c_write_reg(&client, 0x0a, &reg, 1);
> +	if (ret < 0) {
> +		pr_err("Failed to set switch reset time\n");
> +		return ret;
> +	}
>  	/* reset the switch */
>  	reg = 0x01;
> -	i2c_write_reg(&client, 0x0d, &reg, 1);
> +	ret = i2c_write_reg(&client, 0x0d, &reg, 1);
> +	if (ret < 0) {
> +		pr_err("Failed to reset the switch\n");
> +		return ret;
> +	}
>  	/* issue dummy command to work around firmware bug */
> -	i2c_read_reg(&client, 0x01, &reg, 1);
> +	ret = i2c_read_reg(&client, 0x01, &reg, 1);
> +	if (ret < 0) {
> +		pr_err("Failed to issue a dummy command\n");
> +		return ret;
> +	}
>  
>  	return 0;
>  }
> -- 
> 2.21.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox