On Fri, Sep 13, 2019 at 11:24:24PM -0700, Andrey Smirnov wrote:
> Based on a unpublished patch from Andrew Lunn:
>
> The the switch is hardware reset, it reads the contents of the
> EEPROM.
Could you correct this sentence to make its meaning clear?
> This can contain instructions for programming values into
> registers and to perform waits between such programming. Reading
> the EEPROM can take longer than the 100ms
> mv88e6xxx_hardware_reset() waits after deasserting the reset
> GPIO. So poll the EEPROM done bit to ensure it is complete.
>
> Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
>
> @@ -836,6 +865,11 @@ static int mv88e6xxx_probe(struct device_d *dev)
> */
> mv88e6xxx_hardware_reset_delay();
> }
> + /*
> + * Switch will not retrun valid data over MDIO until EEPROM is
> + * loaded
s/retrun/return/
> + */
> + mv88e6xxx_g1_wait_eeprom_done(chip);
>
> err = mv88e6xxx_detect(chip);
> if (err)
> +void mv88e6xxx_g1_wait_eeprom_done(struct mv88e6xxx_chip *chip)
> +{
> + const uint64_t start = get_time_ns();
> + const uint64_t timeout = 20 * SECOND;
> + u16 val;
> + int err;
> +
> + /* Wait up to 1 second for the switch to finish reading the
> + * EEPROM.
> + */
> + while (!is_timeout(start, timeout)) {
> + err = mv88e6xxx_g1_read(chip, MV88E6XXX_G1_STS, &val);
> + if (err) {
> + dev_err(chip->dev, "Error reading status");
> + return;
> + }
> +
> + if (val != 0xFFFF && /* switch will return 0xffff it it */
This comment looks incomplete.
> + val & BIT(MV88E6XXX_G1_STS_IRQ_EEPROM_DONE))
> + return;
> +
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
