On Wed, Feb 06, 2019 at 05:02:37PM -0800, Andrey Smirnov wrote: > > /* > > * The IP has errata ERR004536 > > @@ -612,6 +614,10 @@ static int esdhc_init(struct mci_host *mci, struct device_d *dev) > > /* RSTA doesn't reset MMC_BOOT register, so manually reset it */ > > esdhc_write32(host, SDHCI_MMC_BOOT, 0); > > > > + /* Enable cache snooping */ > > + if (host->socdata->flags & ESDHC_FLAG_CACHE_SNOOPING) > > + esdhc_write32(host, 0x40c, 0x40); > > I think importing ESDHC_DMA_SYSCTL and ESDHC_DMA_SNOOP from Linux and > using them instead of magic number would improve readability. Also, > should this be esdhc_setbits32() instead esdhc_write32() to avoid > clearing other, unrelated, bits? Ok, did that. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
