Hi, On Wed, 2018-10-17 at 10:47 +0200, Sascha Hauer wrote: > the of_reproducible_name mechanism is used to find a partition node > from the barebox devicetree in the Linux devicetree. Unfortunately > we have two different partition bindings. In the legacy one the partition > nodes are directly under the hardware devicenode whereas in the new > binding the partitions are under an additional partitions subnode. > This means we get two different (not so) reproducible names when > the barebox devicetree uses the legacy binding and the Linux devicetree > uses the new binding (or the other way round). To get the same > name then for these cases we drop the partitions subnode from the > reproducible name. > > This makes the partition fixup in barebox-state work when the barebox > devicetree uses another binding than the Linux devicetree. > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Tested-by: Ulrich Ölmann <u.oelmann@xxxxxxxxxxxxxx> Tested-by: Gavin Schenk <g.schenk@xxxxxxxxxxxx> What I did to test it: 1. [x] of_partition_binding=new in barebox and barebox-state in Linux is working. 2. [ ] set of_partition_binding=legacy in barebox and barebox-state in Linux fails. 3. [x] apply the patch and rebuild and install barebox 4. [x] set of_partition_binding=legacy and barebox-state in Linux is working again \o/. Is this test sufficient? If not what are other usefull testcases? Thanks and Regards Gavin Schenk -- Eckelmann AG Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636 http://www.eckelmann.de _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
