On Mon, Oct 15, 2018 at 07:48:37AM -0700, Andrey Smirnov wrote:
> On Mon, Oct 15, 2018 at 2:26 AM Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote:
> >
> > At the moment only ifup stuff turns netif up.
> > After the commit f0624a701513 ('net: Do not route traffic
> > to interfaces that are not up') the dhcp command
> > keeps netif->ifup == false and network subsystem
> > can't route packets.
> >
>
> I am not really trying to make any objections to this patch, however I
> can't seem to find any documented mention that just calling "dhcp" is
> sufficient to bring network up in barebox.
> Documentation/user/networking.rst explicitly tells one to use "ifup"
> for both static and dynamic IP configurations. That being said just
> calling "dhcp" used to work, so this is definitely a regression and it
> might make sense to apply this fix.
Yes, it used to work and it should continue to work, so applied this
one.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
