[PATCH] net: make routing work after dhcp command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At the moment only ifup stuff turns netif up.
After the commit f0624a701513 ('net: Do not route traffic
to interfaces that are not up') the dhcp command
keeps netif->ifup == false and network subsystem
can't route packets.

How to repropduce the problem on qemu-malta_defconfig:

    qemu-system-mips -nodefaults -M malta -m 256 \
                     -nographic -serial stdio -monitor null \
                     -bios barebox-flash-image \
                     -net user -net nic,model=rtl8139

    ...

    barebox:/ dhcp
    eth0: 100Mbps full duplex link detected
    eth0: DHCP client bound to address 10.0.2.15
    barebox:/ ping 10.0.2.2
    ping failed: No route to host

However if ifup command is used for network interface
configuration then there is no network problem, e.g.

    barebox:/ ifup eth0
    eth0: 100Mbps full duplex link detected
    eth0: DHCP client bound to address 10.0.2.15
    barebox:/ ping 10.0.2.2
    host 10.0.2.2 is alive

Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx>
CC: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
---
 net/dhcp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/dhcp.c b/net/dhcp.c
index 984d32a93e..427d80a5a8 100644
--- a/net/dhcp.c
+++ b/net/dhcp.c
@@ -615,6 +615,9 @@ int dhcp(struct eth_device *edev, const struct dhcp_req_param *param)
 
 	dhcp_result_free(res);
 
+	if (!ret)
+		edev->ifup = true;
+
 	return ret;
 }
 
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux