Re: [PATCH v2] ARM: i.MX: increase barebox partition sizes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2016 at 08:47:28AM -0300, Fabio Estevam wrote:
> Hi Sascha,
> 
> On Tue, Apr 26, 2016 at 3:44 AM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> 
> > diff --git a/arch/arm/dts/imx25-karo-tx25.dts b/arch/arm/dts/imx25-karo-tx25.dts
> > index 8d79471..76847ff 100644
> > --- a/arch/arm/dts/imx25-karo-tx25.dts
> > +++ b/arch/arm/dts/imx25-karo-tx25.dts
> > @@ -123,12 +123,12 @@
> >
> >         partition@0 {
> >                 label = "boot";
> > -               reg = <0x0 0x80000>;
> > +               reg = <0x0 0xe0000>;
> >         };
> >
> > -       partition@80000 {
> > +       partition@e0000 {
> >                 label = "environment";
> > -               reg = <0x80000 0x80000>;
> > +               reg = <0xe0000 0x20000>;
> 
> Here the environment partition size is changed from 512kB to 128kB.
> Couldn't this cause issues?

Normally the environment is much smaller, so I wouldn't expect issues
here. The alternative to making the environment smaller would be to move
other partitions to the back. This would probably hurt more, especially
since a regular fdisk starts the first partition at offset 1MiB.

Another approach would be to use a MBR partition for the environment
instead of using the raw device.

> 
> Shouldn't this change be done by a separate patch?

We can't increase the barebox partition without shrinking the
environment right behind it. Or do you mean that we first shrink
the environment and in a second patch increase the barebox partition?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux