On Tue, Jun 11, 2013 at 11:33:06AM +0200, Sebastian Hesselbarth wrote: > On 05/19/13 09:34, Sascha Hauer wrote: > >Hi Sebastian, > > > >On Mon, May 13, 2013 at 01:09:06AM +0200, Sebastian Hesselbarth wrote: > >>This patch adds address translation for default bus types. It has been > >>shamelessly ported from Linux device tree address translation with the > >>following exceptions: > >>- only default bus map and translate are supported > >>- of_bus has not been ported > >>- check for #size-cells > 0 has been removed > >> > >>Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> > > > >I just gave this one a test. > > > >First of all you dropped 1:1 translation, see the attached fixup. > > > >Then, since this code duplicates the majority of drivers/of/address.c, > >would it make sense to move it to the same file in barebox aswell? > > Sascha, > > coming back to this I am wondering if a full sync of linux' drivers/of > with barebox' drivers/of should be done. IMHO at least for the core > stuff (base/address/fdt) it makes sense, of_* can come later if > required. > > I started merging already, and from what I can see we should just remove > the spinlocks and OF_DYNAMIC stuff (but leave of_node_get/_put as stubs) Sounds like a plan. Functions existing both in barebox and Linux should behave the same way. However, if Linux turns out to do something silly or (for our usecase) too bloated, we shouldn't do the same just because Linux does it. I want to keep the Linux list usage in the devicetree, so they won't be really in sync. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
