> This breaks HSIC and has no good justification why this would > be needed for ULPI. > > This reverts commit 2e7d66f526217f6ff3167e4580aecb9548a0de33. > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > --- > drivers/usb/imx/chipidea-imx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/imx/chipidea-imx.c b/drivers/usb/imx/chipidea-imx.c > index 928ebf3..4ee7610 100644 > --- a/drivers/usb/imx/chipidea-imx.c > +++ b/drivers/usb/imx/chipidea-imx.c > @@ -148,13 +148,13 @@ static int imx_chipidea_probe(struct device_d *dev) > ci->data.post_init = imx_chipidea_port_post_init; > ci->data.drvdata = ci; > > + imx_chipidea_port_init(ci); > + > portsc = readl(base + 0x184); > portsc &= ~MXC_EHCI_PORTSC_MASK; > portsc |= ci->flags & MXC_EHCI_PORTSC_MASK; > writel(portsc, base + 0x184); > > - imx_chipidea_port_init(ci); > - > if ((ci->flags & MXC_EHCI_PORTSC_MASK) == MXC_EHCI_MODE_ULPI) { > dev_dbg(dev, "using ULPI phy\n"); > if (IS_ENABLED(CONFIG_USB_ULPI)) { This order was be before driver rework. Unfortunately I can not check right now, but when I test initial version, it was be a proper order, at least for pcm038 (imx27 module). --- _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox