On 23:13 Wed 30 Jan , Sascha Hauer wrote: > On Mon, Jan 21, 2013 at 03:38:01PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> > > --- > > Hi, > > > > just compiled not tested > > Just tested on panda, this does not work. > > > +static __noreturn int omap_xload(void) > > +{ > > + int (*func)(void) = NULL; > > + > > + switch (omap_bootsrc()) > > + { > > { should be in the previous line. > > > + case OMAP_BOOTSRC_MMC1: > > + printf("booting from MMC1\n"); > > + func = bootstrap_read_disk("disk0.0", NULL); > > For some reason the autodetection does not work, with "fat" it works. I > haven't investigated why. Anything else but fat does not make sense > anyway since the OMAP ROM code expects a FAT for the MLO here and barebox > is on the same partition. and so I update the code and re-resend it btw the binary is smaller with the new bootstrap code Best Regards, J. > > > + break; > > + case OMAP_BOOTSRC_USB1: > > + if (IS_ENABLED(CONFIG_FS_OMAP4_USBBOOT)) { > > + printf("booting from USB1\n"); > > + func = bootstrap_read_disk("omap4_usbboot", "omap4_usbbootfs"); > > 'func' is set but not used now. > > Sascha > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox